Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI | Fix TotalIssues=-1 when SCS FF is off (AST-63998) #839

Merged
merged 5 commits into from
Aug 25, 2024

Conversation

AlvoBen
Copy link
Collaborator

@AlvoBen AlvoBen commented Aug 20, 2024

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Fix total issues counter when SCS FF is off

References

https://checkmarx.atlassian.net/browse/AST-63998

Testing

Run tests locally

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@OrShamirCM OrShamirCM requested a review from a team August 20, 2024 07:39
@github-actions github-actions bot added bug Something isn't working fix labels Aug 20, 2024
Copy link

github-actions bot commented Aug 20, 2024

Logo
Checkmarx One – Scan Summary & Details976fc901-dd60-41d8-88f5-6a197a4d5ef5

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

No New Or Fixed Issues Found

Copy link
Contributor

@OrShamirCM OrShamirCM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the tests if they are cover it / add

@AlvoBen AlvoBen merged commit 6f2411f into main Aug 25, 2024
9 checks passed
@AlvoBen AlvoBen deleted the fix/benalvo/fix-total-issues-in-console-summary branch August 25, 2024 11:04
AlvoBen added a commit that referenced this pull request Aug 26, 2024
* fix -1 total issues when scs FF is off

* added unit test

* fix lint

* fix errors

---------

Co-authored-by: AlvoBen <alvo@post.bgu.ac.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants