Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scs support reports v2 (do not merge) (AST-43345) #901

Closed
wants to merge 27 commits into from
Closed

Scs support reports v2 (do not merge) (AST-43345) #901

wants to merge 27 commits into from

Conversation

diogo-fjrocha
Copy link
Collaborator

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change.

References

Include supporting link to GitHub Issue/PR number

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

diogo-fjrocha and others added 27 commits July 9, 2024 11:00
@diogo-fjrocha
Added results to json Summary. Removed code that kept results only to…
5519a6a 
… console summary. Updated unit tests
@diogo-fjrocha
Added SCS to markdown. Added unit tests covering it
4fc3d27
@diogo-fjrocha
Added markdown to default scs integration test
a346259
@diogo-fjrocha
Merge branch 'main' of https://github.com/Checkmarx/ast-cli into AST-…
bca884b 
…43345-scs-support-reports

# Conflicts:
#	internal/commands/result.go
#	internal/commands/result_test.go
#	internal/wrappers/mock/scan-overview-mock.go
@diogo-fjrocha
Fixed unit tests
072f3fd
@diogo-fjrocha
Merge branch 'main' of https://github.com/Checkmarx/ast-cli into AST-…
d9e67d9 
…43345-scs-support-reports
@diogo-fjrocha
Changed scs to scsType in countResult
d331c16
@diogo-fjrocha
Cleaned up code. Improved tests
1c6d4ee
@diogo-fjrocha
Moved removal of sscs results per agent to ReadResults. updated tests
39fa71c
@diogo-fjrocha
Adding sscs results to sarif, needs testing
cb22e31
@diogo-fjrocha
Updated filename field
55e9bf9
@diogo-fjrocha
Added unit tests for Sscs sarif
1dfa423
@diogo-fjrocha
Created new test for RuleID in sarif report
cbd2986
@diogo-fjrocha
Updated the assertTypePresentJSON method
2c72aab
@LeonardoLordelloFontes
Added SCS results to report html format
6332cb8
@LeonardoLordelloFontes
Merge branch 'AST-43345-scs-support-reports' of https://github.com/Ch…
e54a1c5 
…eckmarx/ast-cli into AST-43345-scs-support-reports
@diogo-fjrocha
Added sscs to sonar report. Added snippet to sarif report
20ce4f1
@diogo-fjrocha
Created tests for sonar. Updated existing tests for agents
569a894
@diogo-fjrocha
Merge branch 'AST-43345-scs-support-reports' of https://github.com/Ch…
a416735 
…eckmarx/ast-cli into AST-43345-scs-support-reports
@diogo-fjrocha
Merge branch 'main' of https://github.com/Checkmarx/ast-cli into AST-…
caa2a74 
…43345-scs-support-reports

# Conflicts:
#	internal/commands/result_test.go
@diogo-fjrocha
Created the remaining fields in json report
579aaee
@diogo-fjrocha
Fixed linter issues
649fead
@diogo-fjrocha
Restoring cx_result_sonar file. Adding test for total count in json
2e4f00b
@diogo-fjrocha
Fixing linter result
7093ad6
@diogo-fjrocha
Fix snippet in sarif report
7ad3bdc
@diogo-fjrocha
Moved adding Scs issues to total issues to existing IF block
5a680c3
@diogo-fjrocha
Merge branch 'main' of https://github.com/Checkmarx/ast-cli into AST-…
309e93f 
…43345-scs-support-reports-v2

# Conflicts:
#	internal/commands/result.go
#	internal/commands/scan.go
@OrShamirCM OrShamirCM requested a review from a team October 1, 2024 16:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Logo
Checkmarx One – Scan Summary & Details – c9f6cc3c-e5de-4bc8-a74c-c1abecb1c16b

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

No New Or Fixed Issues Found

@diogo-fjrocha diogo-fjrocha deleted the AST-43345-scs-support-reports-v2 branch October 3, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrShamirCM OrShamirCM Awaiting requested review from OrShamirCM

@AlvoBen AlvoBen Awaiting requested review from AlvoBen AlvoBen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diogo-fjrocha @LeonardoLordelloFontes