Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default from unsupported agents for SCS results (AST-68004) #912

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Remove default from unsupported agents for SCS results (AST-68004) #912

merged 10 commits into from
Nov 5, 2024

Conversation

Korjen97
Copy link
Contributor

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Removed the DefaultAgent from the unsupportedTypesByAgent map in the filterScsResultsByAgent function because it supports all result types (SCSScorecardType and SCSSecretDetectionType). Since its exclusion list was empty, its presence in the map was redundant. This change simplifies the code without affecting functionality, as DefaultAgent never excluded any result types.

References

https://checkmarx.atlassian.net/browse/AST-68004

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@OrShamirCM OrShamirCM requested a review from a team October 16, 2024 08:38
@Korjen97 Korjen97 changed the title Remove astCli from unsupported agents for scs results (AST-68004) other/ Remove astCli from unsupported agents for scs results (AST-68004) Oct 16, 2024
@Korjen97 Korjen97 changed the title other/ Remove astCli from unsupported agents for scs results (AST-68004) Other/ Remove astCli from unsupported agents for scs results (AST-68004) Oct 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 13450b87-5f89-4356-ad9f-0d77d08978d2

No New Or Fixed Issues Found

AlvoBen
AlvoBen previously approved these changes Oct 16, 2024
View reviewed changes
@OrShamirCM OrShamirCM changed the title Other/ Remove astCli from unsupported agents for scs results (AST-68004) Remove Default from unsupported agents for SCS results (AST-68004) Nov 5, 2024
@OrShamirCM OrShamirCM changed the title Remove Default from unsupported agents for SCS results (AST-68004) Remove default from unsupported agents for SCS results (AST-68004) Nov 5, 2024
@OrShamirCM OrShamirCM merged commit ae2ad00 into main Nov 5, 2024
8 of 9 checks passed
@OrShamirCM OrShamirCM deleted the support-containers-scs-with-any-kind-json branch November 5, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrShamirCM OrShamirCM OrShamirCM approved these changes

@AlvoBen AlvoBen AlvoBen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Korjen97 @OrShamirCM @AlvoBen