Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PR Decoration For BB On-cloud and On-prem(AST-70121) #939

Merged
merged 18 commits into from
Nov 18, 2024

Conversation

sarahCx
Copy link
Contributor

@sarahCx sarahCx commented Nov 12, 2024

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Support PR decoration command for Bitbucket.

References

https://checkmarx.atlassian.net/browse/AST-70121

Testing

The integration tests covered successful and failed scenarios, verifying the system's behavior in both on-premises and cloud environments.
Testing a scenario where a scan is running.

Unit test to confirm that all required parameters have been passed.
Unit test to verify the correctness of the function that converts the repo name to the slug format.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@OrShamirCM OrShamirCM requested a review from a team November 12, 2024 15:02
Copy link

github-actions bot commented Nov 12, 2024

Logo
Checkmarx One – Scan Summary & Detailsce8b4f4e-9092-4681-9bfd-005aa86770bf

No New Or Fixed Issues Found

internal/commands/util/pr.go Outdated Show resolved Hide resolved
test/integration/pr_test.go Outdated Show resolved Hide resolved
internal/wrappers/mock/pr-mock.go Show resolved Hide resolved
internal/commands/util/pr.go Show resolved Hide resolved
internal/commands/util/pr.go Show resolved Hide resolved
internal/commands/util/pr.go Show resolved Hide resolved
internal/commands/util/pr.go Show resolved Hide resolved
internal/commands/util/pr.go Show resolved Hide resolved
internal/commands/util/pr.go Show resolved Hide resolved
internal/commands/util/pr.go Outdated Show resolved Hide resolved
internal/commands/util/pr_test.go Show resolved Hide resolved
internal/wrappers/mock/pr-mock.go Show resolved Hide resolved
AlvoBen
AlvoBen previously approved these changes Nov 14, 2024
# Conflicts:
#	cmd/main.go
#	internal/commands/util/pr.go
#	internal/commands/util/pr_test.go
#	internal/params/binds.go
#	internal/params/envs.go
#	internal/params/flags.go
#	internal/params/keys.go
#	internal/wrappers/pr-http.go
#	internal/wrappers/pr.go
#	test/integration/pr_test.go
#	test/integration/util_command.go
@sarahCx sarahCx merged commit 8a0f3da into main Nov 18, 2024
9 checks passed
@sarahCx sarahCx deleted the feature/prDecorationBB branch November 18, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants