fix: add check to avoid illegal index make out of bounds

Signed-off-by: PennyYoon <525296438@qq.com>
Chenxulin97 · Nov 22, 2023 · 1266ebb · 1266ebb
1 parent b89fdc0
commit 1266ebb
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/opengemini/http.go b/opengemini/http.go
@@ -2,6 +2,7 @@ package opengemini
 
 import (
 	"encoding/base64"
+	"errors"
 	"io"
 	"net/http"
 	"net/url"
@@ -42,6 +43,9 @@ func (c *client) executeHttpGetByIdx(idx int, urlPath string, details requestDet
 }
 
 func (c *client) executeHttpRequestByIdx(idx int, method, urlPath string, details requestDetails) (*http.Response, error) {
+	if idx >= len(c.serverUrls) || idx < 0 {
+		return nil, errors.New("index out of range")
+	}
 	serverUrl := c.serverUrls[idx]
 	return c.executeHttpRequest(method, serverUrl, urlPath, details)
 }

diff --git a/opengemini/ping_test.go b/opengemini/ping_test.go
@@ -17,7 +17,7 @@ func TestPingSuccess(t *testing.T) {
 	require.Nil(t, err)
 }
 
-func TestPingFail(t *testing.T) {
+func TestPingFailForInaccessibleAddress(t *testing.T) {
 	c := testNewClient(t, &Config{
 		Addresses: []*Address{{
 			Host: "localhost",
@@ -31,3 +31,17 @@ func TestPingFail(t *testing.T) {
 	err := c.Ping(1)
 	require.NotNil(t, err)
 }
+
+func TestPingFailForOutOfBounds(t *testing.T) {
+	c := testNewClient(t, &Config{
+		Addresses: []*Address{{
+			Host: "localhost",
+			Port: 8086,
+		}},
+	})
+
+	err := c.Ping(1)
+	require.NotNil(t, err)
+	err = c.Ping(-1)
+	require.NotNil(t, err)
+}