Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M2-4928, M2-4929 Drawing and AbTrails streaming updates #604

Merged
merged 6 commits into from
Feb 13, 2024
Merged

M2-4928, M2-4929 Drawing and AbTrails streaming updates #604

merged 6 commits into from
Feb 13, 2024

Conversation

vmkhitaryanscn
Copy link
Contributor

@vmkhitaryanscn vmkhitaryanscn commented Jan 31, 2024 •
edited by jira bot
Loading

M2-4928
M2-4929

Added more information to drawing and abTrails to be sent over the socket

@vmkhitaryanscn
feature(streaming) M2-4928, M2-4929 Added more information to drawing…
9106345 
… and abTrails to be sent over the socket
@vmkhitaryanscn vmkhitaryanscn self-assigned this Jan 31, 2024
anq83
anq83 suggested changes Feb 1, 2024
View reviewed changes
src/entities/abTrail/ui/AbCanvas.tsx Outdated Show resolved Hide resolved
src/entities/abTrail/lib/types/test.ts Outdated Show resolved Hide resolved
src/entities/abTrail/lib/types/test.ts Outdated Show resolved Hide resolved
src/entities/abTrail/ui/AbCanvas.tsx Outdated Show resolved Hide resolved
src/entities/abTrail/ui/AbCanvas.tsx Outdated Show resolved Hide resolved
src/entities/abTrail/ui/AbCanvas.tsx Outdated Show resolved Hide resolved
src/entities/abTrail/ui/AbCanvas.tsx Show resolved Hide resolved
src/entities/abTrail/ui/AbCanvas.tsx Outdated Show resolved Hide resolved
src/entities/drawer/lib/types/draw.ts Outdated Show resolved Hide resolved
src/entities/abTrail/ui/AbCanvas.tsx Outdated Show resolved Hide resolved
anq83
anq83 suggested changes Feb 1, 2024
View reviewed changes
src/entities/abTrail/ui/AbCanvas.tsx Outdated Show resolved Hide resolved
@vmkhitaryanscn vmkhitaryanscn requested a review from anq83 February 1, 2024 13:19
BamMironov
BamMironov suggested changes Feb 1, 2024
View reviewed changes
src/entities/abTrail/lib/utils/streamEventMapper.ts Outdated Show resolved Hide resolved
src/entities/drawer/ui/DrawingBoard.tsx Outdated Show resolved Hide resolved
anq83
anq83 suggested changes Feb 1, 2024
View reviewed changes
src/entities/abTrail/ui/AbCanvas.tsx Outdated Show resolved Hide resolved
src/entities/abTrail/ui/AbCanvas.tsx Outdated Show resolved Hide resolved
src/entities/abTrail/ui/AbCanvas.tsx Outdated Show resolved Hide resolved
anq83
anq83 previously requested changes Feb 5, 2024
View reviewed changes
src/shared/lib/tcp/lib/streamEventMapper.ts Outdated Show resolved Hide resolved
BamMironov
BamMironov suggested changes Feb 6, 2024
View reviewed changes
src/shared/lib/tcp/useSendLiveEvent.ts Outdated Show resolved Hide resolved
@BamMironov BamMironov removed the request for review from anq83 February 13, 2024 11:00
@BamMironov BamMironov dismissed anq83’s stale review February 13, 2024 11:00

the review time has been exceeded

@BamMironov BamMironov merged commit f75b68a into dev Feb 13, 2024
1 check passed
@BamMironov BamMironov deleted the feat/M2-4928_drawing-item-streaming-info-update branch February 13, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BamMironov BamMironov BamMironov approved these changes

@anq83 anq83 anq83 left review comments

Assignees

@vmkhitaryanscn vmkhitaryanscn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmkhitaryanscn @BamMironov @anq83