M2-4997 (common task), M2-5076, M2-4991, M2-5257: add some new mixpanel events #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anq83
force-pushed
the
M2-4997-track-applet-id
branch
2 times, most recently
from
8e24567 to
8449db1
Compare
anq83
force-pushed
the
M2-4997-track-applet-id
branch
from
8449db1 to
a390267
Compare
anq83
changed the title
BamMironov
reviewed
Feb 6, 2024
| appletId={props.route.params.appletId} | ||
| /> | ||
| )} | ||
| {isFocused && <ActivityGroups flex={1} px={14} appletId={appletId} />} |
There was a problem hiding this comment.
Please make sure the groups don't disappear right away during the screen transition animation (e.g. open InProgressActivityScreen)
There was a problem hiding this comment.
There was a problem hiding this comment.
They will and it was before
BamMironov
suggested changes
Feb 6, 2024
| appletId={props.route.params.appletId} | ||
| /> | ||
| )} | ||
| {isFocused && <ActivityGroups flex={1} px={14} appletId={appletId} />} |
There was a problem hiding this comment.
src/shared/lib/hooks/useOnFocus.ts
Outdated
| if (isFocused) { | ||
| callbackRef.current(); | ||
| } | ||
| }, [isFocused]); |
There was a problem hiding this comment.
Please use useFocusEffect instead as it serves exactly the purpose we want to utilize. Here is a quick comparison:
https://www.dhiwise.com/post/how-to-use-the-usefocuseffect-hook-in-react-effectively#comparing-usefocuseffect-and-useisfocused-in-react-native
BamMironov
approved these changes
Feb 6, 2024
anq83
changed the title
anq83
changed the title
anq83
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mindlogger.atlassian.net/browse/M2-4991
https://mindlogger.atlassian.net/browse/M2-5076
https://mindlogger.atlassian.net/browse/M2-4997
https://mindlogger.atlassian.net/browse/M2-5257