Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat/M2-4824 #611

Closed
wants to merge 7 commits into from
Closed

[WIP] feat/M2-4824 #611

wants to merge 7 commits into from

Conversation

jgdev
Copy link
Contributor

@jgdev jgdev commented Feb 6, 2024

No description provided.

@jgdev jgdev requested a review from farmerpaul February 6, 2024 14:39
Copy link
Contributor

@farmerpaul farmerpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jgdev, looks great! I just identified a couple discrepancies and made a few other little suggestions, but otherwise it's looking really good!

src/features/sign-up/ui/SignUpForm.tsx Outdated Show resolved Hide resolved
src/features/sign-up/ui/SignUpForm.tsx Outdated Show resolved Hide resolved
src/features/sign-up/ui/SignUpForm.tsx Outdated Show resolved Hide resolved
src/features/sign-up/ui/SignUpForm.tsx Outdated Show resolved Hide resolved
src/shared/ui/InputIcon.tsx Outdated Show resolved Hide resolved
src/shared/ui/form/InputField.tsx Show resolved Hide resolved
src/shared/ui/form/ErrorMessage.tsx Outdated Show resolved Hide resolved
src/shared/ui/form/ErrorMessage.tsx Outdated Show resolved Hide resolved
src/features/sign-up/ui/SignUpForm.test.tsx Outdated Show resolved Hide resolved
@jgdev jgdev closed this Feb 8, 2024
@jgdev jgdev deleted the feat/M2-4824 branch February 9, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants