Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M2-6235: In progress activity flow/activity name is changing after editing, when it shouldn't #768

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

M2-6235: In progress activity flow/activity name is changing after editing, when it shouldn't #768

wants to merge 6 commits into from

Conversation

vmkhitaryanscn
Copy link
Contributor

📝 Description

🔗 Jira Ticket M2-6235

Changes include:

  • Storing entityName for activity/flow in entityProgress
  • Populating entityName for activity/flow in progressConvert
  • Updated tests , added entityName

@vmkhitaryanscn vmkhitaryanscn self-assigned this May 16, 2024
BamMironov
BamMironov suggested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@BamMironov BamMironov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good. The migration part is missing though. Please create it

src/widgets/activity-group/model/factories/ListItemsFactory.ts Outdated Show resolved Hide resolved
@vmkhitaryanscn vmkhitaryanscn changed the base branch from dev to release/2.0.2 May 17, 2024 12:09
anq83
anq83 suggested changes May 20, 2024
View reviewed changes
src/widgets/activity-group/model/factories/ListItemsFactory.ts Outdated Show resolved Hide resolved
src/widgets/activity-group/model/factories/ListItemsFactory.ts Outdated Show resolved Hide resolved
src/widgets/activity-group/model/factories/ListItemsFactory.ts Show resolved Hide resolved
src/abstract/lib/types/entityProgress.ts Outdated Show resolved Hide resolved
src/abstract/lib/utils/progressConvert.ts Show resolved Hide resolved
src/widgets/activity-group/model/hooks/mocks/mocksForEntities.ts Outdated Show resolved Hide resolved
src/widgets/survey/model/services/tests/testHelpers.ts Outdated Show resolved Hide resolved
src/widgets/survey/model/services/tests/testHelpers.ts Outdated Show resolved Hide resolved
src/widgets/survey/ui/Intermediate.tsx Outdated Show resolved Hide resolved
src/entities/applet/model/slice.ts Outdated Show resolved Hide resolved
@vmkhitaryanscn vmkhitaryanscn changed the base branch from release/2.0.2 to dev May 22, 2024 08:21
@vmkhitaryanscn vmkhitaryanscn changed the base branch from dev to release/2.0.2 May 22, 2024 09:09
@vmkhitaryanscn vmkhitaryanscn changed the base branch from release/2.0.2 to dev May 22, 2024 09:10
@vmkhitaryanscn vmkhitaryanscn changed the base branch from dev to release/2.0.2 May 22, 2024 09:11
@vmkhitaryanscn vmkhitaryanscn changed the base branch from release/2.0.2 to release/2.0.0 May 22, 2024 10:55
@vmkhitaryanscn vmkhitaryanscn changed the base branch from release/2.0.0 to dev May 22, 2024 10:55
@vmkhitaryanscn vmkhitaryanscn requested a review from BamMironov May 22, 2024 11:10
BamMironov
BamMironov suggested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@BamMironov BamMironov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider a bit of refactoring I proposed in the comments

src/app/model/migrations/migrations/to0002/MigrationStorageTypes0002.ts Show resolved Hide resolved
src/app/model/migrations/migrations/to0002/MigrationToVersion0002.ts Outdated Show resolved Hide resolved
src/app/model/migrations/migrations/to0002/MigrationUtils0002.ts Outdated Show resolved Hide resolved
anq83
anq83 suggested changes May 23, 2024
View reviewed changes
src/widgets/activity-group/model/factories/ListItemsFactory.ts Show resolved Hide resolved
src/shared/lib/utils/survey/survey.test.ts Outdated Show resolved Hide resolved
src/widgets/activity-group/model/factories/ActivityGroupsBuilder.test.ts Show resolved Hide resolved
src/entities/notification/model/factory/tests/testHelpers.ts Outdated Show resolved Hide resolved
src/app/model/migrations/migrations/to0002/MigrationUtils0002.ts Outdated Show resolved Hide resolved
src/app/model/migrations/migrations/to0002/MigrationToVersion0002.ts Show resolved Hide resolved
src/app/model/migrations/migrations/to0002/MigrationToVersion0002.ts Outdated Show resolved Hide resolved
src/app/model/migrations/migrations/to0002/MigrationToVersion0002.ts Outdated Show resolved Hide resolved
src/app/model/migrations/migrations/to0002/MigrationDtoTypes0002.ts Outdated Show resolved Hide resolved
src/app/model/migrations/migrations/to0002/MigrationUtils0002.ts Outdated Show resolved Hide resolved
@anq83
Copy link
Contributor

anq83 commented Jun 4, 2024

Do not merge until MIGRATION_PROCESSOR_VERSION is actual (=2)

@vmkhitaryanscn vmkhitaryanscn marked this pull request as draft June 5, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anq83 anq83 anq83 approved these changes

@BamMironov BamMironov BamMironov approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@vmkhitaryanscn vmkhitaryanscn

Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vmkhitaryanscn @anq83 @BamMironov @AlekseyNalivaiko