M2-7967: fix input tap detection #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on event fire correctly
…oving from Game Manager
felipeMetaLab
commented
Oct 26, 2024
|
In this PR I left a lot of comment in the code to facilitate the test, but it will be removed once it get approved. |
|
I left a lot of comment to facilitate the understanding, once it get approved I will remove all comments. |
added 2 commits
October 29, 2024 10:36
|
comments removed |
ChaconC
reviewed
Oct 29, 2024
added 11 commits
October 30, 2024 20:39
…ementing setEndTimeViewingImage that allows it to capture precise timing information for each phase of your game, Increment countTest Before Checking isEndGame,adjusting isEndGame method ...
felipeMetaLab
changed the title
ChaconC
reviewed
Nov 13, 2024
added 9 commits
November 13, 2024 15:55
ChaconC
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Thanks @felipeMetaLab
Tested multiple runs and all taps appear registered correct now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-7967
Solution Explanation:
this is a continuation of #870.
This time I am handling the enable and disable button.
📸 Screenshots
Simple Choice Reaction Time task:
test.reaction.mov
🪤 Peer Testing
Before:
Input will be ignored the longer you wait to tap the button (disabled state)
Expected:
now you will be able to click all the times.