fix: add applets refresh after answers submission (M2-8144) #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbanting
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Verified this fixes the issue. Out of curiosity, I also tested this with an older version, 2.3.1 and the issue wasn't there. So this was introduced in 2.4.0. Ideally we revisit this and determine what the root cause is (I'll add a task to the backlog), but refreshing can work in the interim. Code LGTM. Thanks @qiushihe
mbanting
pushed a commit
that referenced
this pull request
Oct 31, 2024
Co-authored-by: Billie He <billy@metalab.com>
farmerpaul
added a commit
that referenced
this pull request
Oct 31, 2024
This reverts commit 34b9471.
farmerpaul
added a commit
that referenced
this pull request
Oct 31, 2024
This reverts commit 34b9471.
farmerpaul
added a commit
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-8144
This PR adds an extra step to refresh applets data after answers are submitted.
This addition is meant to address the issue in M2-8144, where when an daily activity is completed via notification, the activity does not disappear from the list of activities. In that case, the activity would disappear from the list if the user goes to refresh the applet. So this PR inserts the same refresh call to the end of the answers submission queue processor. So now, regardless if a activity is completed from the activities listing screen, or from notification, the applets will be refreshed after answers submission.
📸 Screenshots
N/A
🪤 Peer Testing
At this point, the just completed activity should no longer appear in the activities listing screen.
✏️ Notes
N/A