Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2-8255: fix timing mismatch #900

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

felipeMetaLab
Copy link
Contributor

@felipeMetaLab felipeMetaLab commented Nov 20, 2024

📝 Description

🔗 Jira Ticket M2-8255
The issue was primarily due to the timing mismatch between when the user could interact with the UI and when the app was ready to process input.
reordering the sequence of operations, we align the app readiness with the user ability to interact.

📸 Screenshots

ISSUE VIDEO:

srt.issue.mp4

🪤 Peer Testing

  • lauch the app
  • Create a Serial Reaction Time performance task
  • Set time between screens to more than 1000ms (Show each stimulus for)
  • Run task on an iOS device
  • When the button is presented, wait at least 500ms and then attempt to tap the button

There were 2 ways to reproduce the issue easily on my side:

  • tap the button as many times as possible
  • tap the button as accurate as possible (stimulus is shown for 500 ms)

✏️ Notes

Check more information on the comments of this ticket:
https://mindlogger.atlassian.net/browse/M2-7967

@felipeMetaLab felipeMetaLab changed the title Fix/setting unix time stamp to input tap detection Fix/ fixing timing mismatch Nov 20, 2024
@ChaconC ChaconC changed the title Fix/ fixing timing mismatch M2-8255: fix timing mismatch Nov 22, 2024
@felipeMetaLab felipeMetaLab merged commit 9ce54ae into dev Nov 26, 2024
5 checks passed
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
* feature/adding unix time

* fix creating boot time to fix the timestamp result

* fix/Fixing timing mismatch between taps

* reverting some files

* fixing identation

* fixing redundant call, and ensuring the button will be disabled before user action

* new formating and fixing index out of range

---------

Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
* feature/adding unix time

* fix creating boot time to fix the timestamp result

* fix/Fixing timing mismatch between taps

* reverting some files

* fixing identation

* fixing redundant call, and ensuring the button will be disabled before user action

* new formating and fixing index out of range

---------

Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
* feature/adding unix time

* fix creating boot time to fix the timestamp result

* fix/Fixing timing mismatch between taps

* reverting some files

* fixing identation

* fixing redundant call, and ensuring the button will be disabled before user action

* new formating and fixing index out of range

---------

Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
* feature/adding unix time

* fix creating boot time to fix the timestamp result

* fix/Fixing timing mismatch between taps

* reverting some files

* fixing identation

* fixing redundant call, and ensuring the button will be disabled before user action

* new formating and fixing index out of range

---------

Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
* feature/adding unix time

* fix creating boot time to fix the timestamp result

* fix/Fixing timing mismatch between taps

* reverting some files

* fixing identation

* fixing redundant call, and ensuring the button will be disabled before user action

* new formating and fixing index out of range

---------

Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
* feature/adding unix time

* fix creating boot time to fix the timestamp result

* fix/Fixing timing mismatch between taps

* reverting some files

* fixing identation

* fixing redundant call, and ensuring the button will be disabled before user action

* new formating and fixing index out of range

---------

Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
* feature/adding unix time

* fix creating boot time to fix the timestamp result

* fix/Fixing timing mismatch between taps

* reverting some files

* fixing identation

* fixing redundant call, and ensuring the button will be disabled before user action

* new formating and fixing index out of range

---------

Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
* feature/adding unix time

* fix creating boot time to fix the timestamp result

* fix/Fixing timing mismatch between taps

* reverting some files

* fixing identation

* fixing redundant call, and ensuring the button will be disabled before user action

* new formating and fixing index out of range

---------

Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants