-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M2-8255: fix timing mismatch #900
Merged
felipeMetaLab
merged 8 commits into
dev
from
fix/settingUnixTimeStampToInputTapDetection
Nov 26, 2024
Merged
M2-8255: fix timing mismatch #900
felipeMetaLab
merged 8 commits into
dev
from
fix/settingUnixTimeStampToInputTapDetection
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeMetaLab
changed the title
Fix/setting unix time stamp to input tap detection
Fix/ fixing timing mismatch
Nov 20, 2024
ChaconC
reviewed
Nov 22, 2024
ChaconC
approved these changes
Nov 25, 2024
ChaconC
pushed a commit
that referenced
this pull request
Dec 6, 2024
* feature/adding unix time * fix creating boot time to fix the timestamp result * fix/Fixing timing mismatch between taps * reverting some files * fixing identation * fixing redundant call, and ensuring the button will be disabled before user action * new formating and fixing index out of range --------- Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC
pushed a commit
that referenced
this pull request
Dec 6, 2024
* feature/adding unix time * fix creating boot time to fix the timestamp result * fix/Fixing timing mismatch between taps * reverting some files * fixing identation * fixing redundant call, and ensuring the button will be disabled before user action * new formating and fixing index out of range --------- Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC
pushed a commit
that referenced
this pull request
Dec 6, 2024
* feature/adding unix time * fix creating boot time to fix the timestamp result * fix/Fixing timing mismatch between taps * reverting some files * fixing identation * fixing redundant call, and ensuring the button will be disabled before user action * new formating and fixing index out of range --------- Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC
pushed a commit
that referenced
this pull request
Dec 6, 2024
* feature/adding unix time * fix creating boot time to fix the timestamp result * fix/Fixing timing mismatch between taps * reverting some files * fixing identation * fixing redundant call, and ensuring the button will be disabled before user action * new formating and fixing index out of range --------- Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC
pushed a commit
that referenced
this pull request
Dec 6, 2024
* feature/adding unix time * fix creating boot time to fix the timestamp result * fix/Fixing timing mismatch between taps * reverting some files * fixing identation * fixing redundant call, and ensuring the button will be disabled before user action * new formating and fixing index out of range --------- Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC
pushed a commit
that referenced
this pull request
Dec 6, 2024
* feature/adding unix time * fix creating boot time to fix the timestamp result * fix/Fixing timing mismatch between taps * reverting some files * fixing identation * fixing redundant call, and ensuring the button will be disabled before user action * new formating and fixing index out of range --------- Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC
pushed a commit
that referenced
this pull request
Dec 6, 2024
* feature/adding unix time * fix creating boot time to fix the timestamp result * fix/Fixing timing mismatch between taps * reverting some files * fixing identation * fixing redundant call, and ensuring the button will be disabled before user action * new formating and fixing index out of range --------- Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC
pushed a commit
that referenced
this pull request
Dec 6, 2024
* feature/adding unix time * fix creating boot time to fix the timestamp result * fix/Fixing timing mismatch between taps * reverting some files * fixing identation * fixing redundant call, and ensuring the button will be disabled before user action * new formating and fixing index out of range --------- Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-8255
The issue was primarily due to the timing mismatch between when the user could interact with the UI and when the app was ready to process input.
reordering the sequence of operations, we align the app readiness with the user ability to interact.
📸 Screenshots
ISSUE VIDEO:
srt.issue.mp4
🪤 Peer Testing
There were 2 ways to reproduce the issue easily on my side:
✏️ Notes
Check more information on the comments of this ticket:
https://mindlogger.atlassian.net/browse/M2-7967