Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting Back button translatable #904

Merged
merged 1 commit into from
Nov 25, 2024
Merged

setting Back button translatable #904

merged 1 commit into from
Nov 25, 2024

Conversation

felipeMetaLab
Copy link
Contributor

📝 Description

🔗 Jira Ticket M2-8137

Turning Back button into translatable button.

📸 Screenshots

Screenshot 2024-11-24 at 5 52 59 PM Screenshot 2024-11-24 at 5 53 12 PM Screenshot 2024-11-24 at 5 53 30 PM

🪤 Peer Testing

  • Launch the App.
  • change the language to a desired language.
  • go to some page that has "Back Button" such as create account.

andrevitalb
andrevitalb approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@andrevitalb andrevitalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple!

@felipeMetaLab felipeMetaLab merged commit 1b1e6be into dev Nov 25, 2024
5 checks passed
@ChaconC ChaconC deleted the fix/M2-8137_translating_back_button branch November 26, 2024 21:07
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
@felipeMetaLab @ChaconC
fix: setting Back button translatable M2-8137 (#904)
e3982a2 
Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
@felipeMetaLab @ChaconC
fix: setting Back button translatable M2-8137 (#904)
820b847 
Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
@felipeMetaLab @ChaconC
fix: setting Back button translatable M2-8137 (#904)
d7f2b05 
Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
@felipeMetaLab @ChaconC
fix: setting Back button translatable M2-8137 (#904)
081c926 
Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
@felipeMetaLab @ChaconC
fix: setting Back button translatable M2-8137 (#904)
458f243 
Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
@felipeMetaLab @ChaconC
fix: setting Back button translatable M2-8137 (#904)
a16d23b 
Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
@felipeMetaLab @ChaconC
fix: setting Back button translatable M2-8137 (#904)
a7da1bf 
Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
ChaconC pushed a commit that referenced this pull request Dec 6, 2024
@felipeMetaLab @ChaconC
fix: setting Back button translatable M2-8137 (#904)
3126eab 
Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrevitalb andrevitalb andrevitalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipeMetaLab @andrevitalb