Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: M2 8318 finxing between dates and outside dates #911

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Fix: M2 8318 finxing between dates and outside dates #911

merged 3 commits into from
Dec 4, 2024

Conversation

felipeMetaLab
Copy link
Contributor

📝 Description

🔗 Jira Ticket M2-8318
finxing between dates and outside dates

📸 Screenshots

Screenshot 2024-12-02 at 3 56 46 PM

Screen.Recording.2024-12-02.at.3.50.15.PM.mov

🪤 Peer Testing

1 - Create an activity with date item and create the conditional logic Between or outside of, similar to the screen shot I left.
2 - launch the app and check if Boundary value is considered as a valid response.

@ChaconC ChaconC merged commit b7b9b2b into dev Dec 4, 2024
5 checks passed
@ChaconC ChaconC deleted the fix/M2-8318_finxing_between_Dates branch December 4, 2024 16:08
ChaconC pushed a commit that referenced this pull request Dec 4, 2024
@felipeMetaLab @ChaconC
fix: fixing between dates and outside dates (M2-8318) (#911)
80596a5 
* fix: fixing isBetweenDates logic

* fixing isOutsideOfDates logic

* reverting podfile

---------

Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaconC ChaconC ChaconC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipeMetaLab @ChaconC