Maybe fix some concurrency warnings #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really appreciate you takig a shot at this. I'm currently unable to look closely, but I promise that I will soon! |
|
Thanks so much for this, all of these look good. I'm not sure what's up with the tests, but I don't think it is related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgive me if this is the wrong approach, still wrapping my head around some of this stuff. (Thanks for all the great resources btw!) The gist of the PR is changing stored
static lets to computedstatic vars.I think Xcode also reformatted according to the .editorconfig? Let me know if you don't want those changes as part of this, I'm happy to remove them if so.