Add recipe json-ld extraction #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egh
force-pushed
the
json-ld
branch
3 times, most recently
from
b217f19
to
bc4b54b
Compare
|
Thanks for looking into this! This looks great, I wasn't aware of this, and I'm excited to have this functionality added. One thing that I'm noticing, though, is that this uses Thanks again :). |
Many recipe sites include recipe data in the JSON-LD format (see https://developers.google.com/search/docs/data-types/recipe) Add a recipe extractor for JSON-LD format and prefer it if org-chef-prefer-json-ld is set. Otherwise, use it as a last resort.
|
Seems to be working now! I do get a "Bad string format" error with the weber recipes, though. https://www.weber.com/US/en/recipes/red-meat/the-ultimate-burger/weber-2008421.html But we can figure this out later :). Thanks for submitting this! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many (most?) recipe sites include recipe data in the JSON-LD format (see https://developers.google.com/search/docs/data-types/recipe)
This adds a recipe extractor for JSON-LD format.
Many of the built in sites that org-chef supports also support JSON-LD (Fine Cooking, Serious Eats, Allrecipes, NYT, etc). I think that using JSON-LD would be easier to maintain, because it should be a more stable data format than parsing the html.
In order to test this extractor against the custom extractor, I defined a custom variable
org-chef-prefer-json-ld. If it ist,org-chefwill prefer to use the JSON-LD extractor. Otherwise, it is used as a last resort only.This addresses #16 and #48 and (I think) #49