Correctly handle multiple passed upgrade proposals acc to cosmos-sdk #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sin3point14
commented
Nov 29, 2024
Comment on lines
-69
to
+90
| newProposal(t, 3, 200, v1.StatusPassed), | ||
| newProposal(t, 3, 200, v1.StatusDepositPeriod), |
There was a problem hiding this comment.
I needed to change the status here as the newly added logic would cancel the proposal at height 100 seeing a passed upgrade at 200, which is the correct behaviour.
If multiple passed upgrade proposals are in the "passed" state, the cosmos upgrade handler only treats the one with the highest proposal ID as "passed" and all other passed proposals as "cancelled". https://github.com/cosmos/cosmos-sdk/blob/f007a4ea0711da2bac20afc6283885c1b2496ae5/x/upgrade/keeper/keeper.go#L189-L193
sin3point14
force-pushed
the
multiple-passed-props
branch
from
4ac9478 to
e389757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple passed upgrade proposals are in the "passed" state, the cosmos upgrade handler only treats the one with the highest proposal ID as "passed" and all other passed proposals as "cancelled".
ref: https://github.com/cosmos/cosmos-sdk/blob/f007a4ea0711da2bac20afc6283885c1b2496ae5/x/upgrade/keeper/keeper.go#L189-L193.
Thanks to the zetachain team for discovering this.