Don't require container to be down in dcc.Down

[sin3point14]

The check can be racy, let the caller do whatever checks it wants to do. daemon.go already has a check where it decides if dcc.Down is needed or not. Now we also add a check to RestartServiceWithHaltHeight before it calls Down, with an appropriate error message.

Closes #25

Not sure how I can add tests for this :(, suggestions welcome!

[sin3point14]

This is one way to do this, another way is to let the check be there dcc.Down and treat ErrContainerNotRunning as a warning in wherever it is called. However then that check too is racy, container can be running at

blazar/internal/pkg/docker/compose.go

Line 185 in a2c9d9b

isImageContainerRunning, err := dcc.IsServiceRunning(ctx, serviceName, timeout)

but exits by the time execution reaches

blazar/internal/pkg/docker/compose.go

Line 198 in a2c9d9b

err = cmd.ExecuteWithDeadlineAndLog(ctx, deadline, []string{}, "docker", "compose", "-f", dcc.composeFile, "down", "--remove-orphans", "-t", strconv.Itoa(timeoutSeconds))

.

I just went with this way as it felt like the natural solution, but if the other method is better, I can surely change to that.

[mkaczanowski]

LGTM