Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust privatenet config to satisfy Web3signer 23.9.1 #3

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

mksh
Copy link
Contributor

@mksh mksh commented Oct 17, 2023

Fixes web3signer errors

Error parsing parameters: Failed to load network /opt/privatenet/config.yaml due to Missing value for spec constant 'GOSSIP_MAX_SIZE'

@mksh mksh force-pushed the ethereum-clients-adjustments-oct2023 branch from a2ab3ac to cccfe71 Compare October 18, 2023 11:01
@mksh mksh requested review from a team October 18, 2023 11:35
@mksh mksh marked this pull request as ready for review October 18, 2023 11:35
Copy link

@hritique hritique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of all these new flags, assuming they all work(tested)

@mksh
Copy link
Contributor Author

mksh commented Oct 18, 2023

I'm not aware of all these new flags, assuming they all work(tested)

These are for ongoing gossip efficiency tuning and also Deneb upgrades, Teku/Web3signer codebase validates every flag that is used in the code to be present in YAML, that's why need to add them.

There is automated test of validator deposit & exit happening in CI: https://github.com/ChorusOne/eth-possim/actions/runs/6559917857/job/17816496239?pr=3

@mksh mksh merged commit b6a2722 into main Oct 18, 2023
1 check passed
@mksh mksh deleted the ethereum-clients-adjustments-oct2023 branch October 18, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants