Add fee rewards manager to possim #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@enriquefynn @mksh what's up with the test failing? seems unrelated to the changes? |
Adds ability to deploy compiled contracts, this should be favoured instead of compiling contracts with solc, it's more reliable because we can use the exact same bytecode that is deployed in the Ethereum blockchain. For the fee manager contract we need 2 contracts, first the library and then the main contract, we deploy the library contract and substitute a placeholder inside the compiled binary with the library's address.
enriquefynn
force-pushed
the
include_fee_manager_contract
branch
from
6b7d26a to
0704d20
Compare
jenpaff
reviewed
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to deploy compiled contracts, this should be favoured instead of compiling contracts with solc, it's more reliable because we can use the exact same bytecode that is deployed in the Ethereum blockchain.
For the fee manager contract we need 2 contracts, first the library and then the main contract, we deploy the library contract and substitute a placeholder inside the compiled binary with the library's address.