-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirements of WSI image for registration to work? #2
Comments
Dear Rutger, I appreciate your interest in our registration algorithm and implementation. parameters = {
# feature extractor parameters
"point_extractor": "sift", #orb , sift
"maxFeatures": 512,
"crossCheck": False,
"flann": False,
"ratio": 0.6,
"use_gray": False,
# QTree parameter
"homography": True,
"filter_outliner": False,
"debug": False,
"target_depth": 1,
"run_async": True,
"num_workers: 2,
"thumbnail_size": (1024, 1024)
} As the paper explains, our algorithm works best on cytology images or when the same slide is digitised with different stains. With kind regards, |
Dear Rutger, with Please try: The upper case actually should work and looks good. But without the data, I have no chance of figuring out what's going on. Please also have a look at the examples we provided: With kind regards, |
Hi Christian, I hope you had a nice time on your holidays! So, I checked out your code a little deeper and I think I know what is the problem if the source and target WSI are rotated w.r.t. each other: openslide does not allow you to request a rotated square from the WSI. Your SIFT algorithm is able to find rotationally invariant keypoints (so it will find matching points even if the WSIs are rotated w.r.t. each other). However, in the code as it is (I believe) you can't query a rotated image in your debug mode, so it returns some garbage crop that makes no sense. Did you not account for rotated images in your approach? (it is quite common) Moreover, I appreciate the setup of the repo and your approach but I have some questions:
Thanks for your help, |
Dear Ruther, Thanks for the interest in the repository. Thanks for hinting what the problem with the rotated images could be. I will look into that as soon as possible. I plan to do the following with this repository soon (Q1 2022).
Regard your question. I´m currently not planning to integrate functions to transform WSIs to the target space. With kind regards, |
Hi Christian, Best, |
Hello,
I found your repo following your COMPAY publication, congratulations on that!
However, I've been trying out the example on your main README.md with some of my local images (HER2 or KI67 to HE), but I find that the registration returns an error for various (opencv internal) reasons - it can't find a homology or some function returns None - OR it returns a very poor registration no matter what parameters I perturb.
The registration is poor if I give it cross-stain images to register (HER2 to HE or KI67 to HE), even though the images look pretty aligned and similar. If I give the same HE image as input and target then the registration works (so at least that sanity test works).
My images are .svs files that only contain a 40x magnification.
Are there any hidden parameters or requirements that a WSI file must have that the code intrinsically uses? Must it be a pyramid image for example?
Thank you for your help,
Rutger
The text was updated successfully, but these errors were encountered: