merge dev into next #199
Merged
merge dev into next #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression with databases connections that set an explicit `sslmode`. Previously we had disabled it for all cases, assuming no parameter would be provided. This time we adapt to the possible case, in which an SSL mode is provided, but in a notation not known by PostgreSQL. We have seen cases, in which `no-verify` is specified for configuring the `api-server` `psql` client, which we set to `require`, instead of the (possibly insecure) default of `prefer`. To cite https://www.postgresql.org/docs/current/libpq-ssl.html#LIBQ-SSL-CERTIFICATES "By default, PostgreSQL will not perform any verification of the server certificate." This differs from the default in the Postgres library we use `pq`, citing https://node-postgres.com/announcements#2020-02-25 "Now we will use the default ssl options to tls.connect which includes rejectUnauthorized being enabled. This means your connection attempt may fail if you are using a self-signed cert." As per that announcement, the behaviour is intentionally inherited from: - https://nodejs.org/api/tls.html#tls_tls_connect_options_callback As specifying an `sslmode`, even with `no-verify`, implies that we want to enforce a secure connection, we are falling back to a sane default, `require`. Reference: - https://www.postgresql.org/docs/current/libpq-ssl.html#LIBPQ-SSL-SSLMODE-STATEMENTS - https://github.com/brianc/node-postgres/blob/46cfb25baf8fdba87f71c3888fcb0021eaf829d3/packages/pg-connection-string/README.md?plain=1#L69-L72 - https://github.com/brianc/node-postgres/blob/master/packages/pg/lib/connection-parameters.js#L30-L31 - https://github.com/brianc/node-postgres/blob/master/packages/pg-connection-string/index.js#L98-L101 - brianc/node-postgres#2720
…the-root-organization-in-the-marketplace filter the OPERATOR_ORGANIZATION from the market list (allBusinesses)
…er by "createdAt")
…r-cursor-pagination-is-not-consistent add a secondary order column for columns that contain duplicates (ord…
…r-cursor-pagination-is-not-consistent 0.9.8
APP-366: fix(migrations/container): sslmode cases
…se-location-table-for-survey add the new villages
…or-user-to-delete-their-shop-api Feature/app 196 add ability for user to delete their shop api
…or-user-to-delete-their-shop-api add migration to set shops to enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.