Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

206 replace safe sdk #216

Merged
merged 10 commits into from
Aug 17, 2023
Merged

206 replace safe sdk #216

merged 10 commits into from
Aug 17, 2023

Conversation

juanenrisley
Copy link
Collaborator

@juanenrisley juanenrisley commented Aug 4, 2023 •
edited
Loading

Closes #206

  • Replace functionality in safe.js to use safe-core-sdk and circles-payment-api
  • Create tests
  • Document all methods

@juanenrisley
Copy link
Collaborator Author

juanenrisley commented Aug 4, 2023 •
edited
Loading

Tests are failing because they run against circles-docker and there is no circles-payment-api there yet. If you run them in local, they pass. You can test them in local if you:

  1. Run circles-docker images
  2. Run cirles-paymment-api in local
  3. Set the environment variable RELAY_SERVICE_ENDPOINT to point to the new service in the .env file of circles-core
  4. Run the circles-core tests

EDIT: tests passing now, not need to launch in local

JacqueGM
JacqueGM reviewed Aug 14, 2023
View reviewed changes
src/safe.js Show resolved Hide resolved
@juanenrisley juanenrisley merged commit 690fa7e into relayer-replacement Aug 17, 2023
1 check failed
@juanenrisley juanenrisley deleted the 206-replace-safe-sdk branch August 17, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacqueGM JacqueGM JacqueGM left review comments

@llunaCreixent llunaCreixent Awaiting requested review from llunaCreixent llunaCreixent is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanenrisley @JacqueGM