Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds logging and changes return status for bad temp dir: Issue #1028 #1037

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Adds logging and changes return status for bad temp dir: Issue #1028 #1037

merged 1 commit into from
Oct 16, 2023

Conversation

Kiggins26
Copy link
Contributor

@Kiggins26 Kiggins26 commented Sep 27, 2023 •
edited by micahsnyder
Loading

Resolves: #1028

@Kiggins26 Kiggins26 marked this pull request as ready for review September 27, 2023 22:56
@micahsnyder micahsnyder self-assigned this Sep 28, 2023
micahsnyder
micahsnyder requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@micahsnyder micahsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little more detail explaining why we care of the directory is invalid/doesn't exist would be good. Otherwise this seems like the right fix to me.

clamd/clamd.c Outdated Show resolved Hide resolved
clamd/session.c Outdated Show resolved Hide resolved
@Kiggins26 Kiggins26 force-pushed the InvalidTempDirFix branch 2 times, most recently from afe9479 to 0c464fb Compare September 29, 2023 00:06
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 2, 2023
View reviewed changes
clamd/clamd.c Fixed Show resolved Hide resolved
clamd/session.c Fixed Show fixed Hide fixed
micahsnyder
micahsnyder reviewed Oct 2, 2023
View reviewed changes
clamd/clamd.c Outdated Show resolved Hide resolved
micahsnyder
micahsnyder requested changes Oct 2, 2023
View reviewed changes
clamd/clamd.c Fixed Show resolved Hide resolved
clamd/clamd.c Outdated Show resolved Hide resolved
clamd/clamd.c Outdated Show resolved Hide resolved
@Kiggins26 Kiggins26 requested a review from micahsnyder October 3, 2023 22:05
micahsnyder
micahsnyder approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@micahsnyder micahsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the help @Kiggins26!

@micahsnyder micahsnyder merged commit 6f82ba4 into Cisco-Talos:main Oct 16, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahsnyder micahsnyder micahsnyder approved these changes

Assignees

@micahsnyder micahsnyder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClamD fails silently if temporary folder does not exist
2 participants
@Kiggins26 @micahsnyder