Skip to content

Commit

Permalink
Resolve meraki network query by id returns empty data object (#442)
Browse files Browse the repository at this point in the history
* Added test coverage for Issue #441 query by net_id

* Enabled query by net_id

* Added changelog fragment to branch
  • Loading branch information
mystery-rabbit authored Feb 15, 2023
1 parent 906a784 commit 9df86d2
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- Enables meraki_network query by net_id (https://github.com/CiscoDevNet/ansible-meraki/issues/441)
2 changes: 1 addition & 1 deletion plugins/modules/meraki_network.py
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ def main():
meraki.exit_json(**meraki.result)
else:
meraki.result["data"] = meraki.get_net(
meraki.params["org_name"], meraki.params["net_name"], data=nets
meraki.params["org_name"], net_name=meraki.params["net_name"], data=nets, net_id=meraki.params["net_id"],
)
meraki.exit_json(**meraki.result)
elif meraki.params["state"] == "present":
Expand Down
25 changes: 24 additions & 1 deletion tests/integration/targets/meraki_network/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -453,12 +453,35 @@
delegate_to: localhost
register: net_query_one

- name: Query assertions
- name: Query one network - assert
assert:
that:
- 'net_query_one.data.name == "IntTestNetworkSwitch"'
- 'query_config_template.data.name == "{{ test_template_name }}"'

- name: Set net_id
ansible.builtin.set_fact:
net_id: "{{ net_query_one.data.id }}"

- name: Query one network by ID
cisco.meraki.meraki_network:
auth_key: '{{ auth_key }}'
state: query
org_name: '{{test_org_name}}'
net_id: "{{ net_id}}"
delegate_to: localhost
register: net_query_one_id

- name: Query one network by ID - debug
ansible.builtin.debug:
var: net_query_one_id

- name: Query one network by ID - assert
ansible.builtin.assert:
that:
- 'net_query_one_id.data.name == "IntTestNetworkSwitch"'
- 'query_config_template.data.name == "{{ test_template_name }}"'

#############################################################################
# Tear down starts here
#############################################################################
Expand Down

0 comments on commit 9df86d2

Please sign in to comment.