🐞 Fix: Mandan source value #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimmonsRitchie
force-pushed
the
fix/mandan-source
branch
from
966a5bf
to
52337c5
Compare
SimmonsRitchie
force-pushed
the
fix/mandan-source
branch
from
52337c5
to
29cba67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Set the value for the source field for Mandan City feeds to the the agency's website rather than the API response.
Why are we doing this?
To scrape Mandan, we target the city's API. We were using a link to the JSON response in our
sourcefield but this was confusing our partners. Instead, we've updated this to just use the agency's user-facing calendar page as thesourcevalue.Steps to manually test
Are there any smells or added technical debt to note?