🏗️ Build mixin + spiders: bisnd_mc #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LienDang
reviewed
Mar 19, 2024
city_scrapers/mixins/mc.py
Outdated
|
|
||
| def start_requests(self): | ||
| """ | ||
| sdfsdfsdf |
There was a problem hiding this comment.
Yep. Now fixed!
city_scrapers/mixins/mc.py
Outdated
| # Calculate dates for one month prior and one year ahead | ||
| today = datetime.today() | ||
| one_month_prior = today - relativedelta(months=1) | ||
| one_year_ahead = today + relativedelta(months=6) |
There was a problem hiding this comment.
Naming issue one_year_ahead vs. half_year_ahead?
There was a problem hiding this comment.
Yep. Now fixed!
city_scrapers/mixins/mc.py
Outdated
| links.append( | ||
| { | ||
| "title": file["name"], | ||
| "href": f"https://mandannd.api.civicclerk.com/v1/Meetings/GetMeetingFileStream(fileId={file['fileId']},plainText=false)", # noqa |
There was a problem hiding this comment.
You can replace https://mandannd.api.civicclerk.com with {self.base_url}
There was a problem hiding this comment.
Yep. That's def tidier. Thanks, @LienDang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds a mixin and spiders to scrape multiple commission/boards from the website of the City of Mandan in Mandan, ND. The mixin that handles the core scraping logic is called
bisnd_mc.Why are we doing this?
Requested by our site partners.
Steps to manually test
Monitor the output and ensure no errors are raised.
Inspect the CSVs to ensure the data looks valid. You can view the value in the "source" column of the rows to ensure the data matches.
Are there any smells or added technical debt to note?