From 53daf624006b63b12d1bb13b931a1d2149e1fc54 Mon Sep 17 00:00:00 2001 From: Daniel Simmons-Ritchie <37225902+SimmonsRitchie@users.noreply.github.com> Date: Tue, 30 Apr 2024 10:24:00 -0500 Subject: [PATCH 1/3] Enable logs --- .deploy.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.deploy.sh b/.deploy.sh index 3971883..9337576 100755 --- a/.deploy.sh +++ b/.deploy.sh @@ -1,5 +1,5 @@ #!/bin/bash -pipenv run scrapy list | xargs -I {} pipenv run scrapy crawl {} -s LOG_ENABLED=False & +pipenv run scrapy list | xargs -I {} pipenv run scrapy crawl {} -s LOG_ENABLED=True & # Output to the screen every 9 minutes to prevent a travis timeout # https://stackoverflow.com/a/40800348 From 0cb7e59c01e95a834d0d6ee016a0254ac2e0b0b7 Mon Sep 17 00:00:00 2001 From: Daniel Simmons-Ritchie <37225902+SimmonsRitchie@users.noreply.github.com> Date: Tue, 30 Apr 2024 10:25:18 -0500 Subject: [PATCH 2/3] Ignore csv --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index dc864e5..cb6ff0f 100644 --- a/.gitignore +++ b/.gitignore @@ -134,3 +134,4 @@ logs/*.log travis/*.json # output files: local gitignore added to city_scrapers/local_outputs/ +*.csv From 23ad15d202d8e8f03620dcf362a1d2fc3a7b07c1 Mon Sep 17 00:00:00 2001 From: Daniel Simmons-Ritchie <37225902+SimmonsRitchie@users.noreply.github.com> Date: Tue, 30 Apr 2024 10:25:27 -0500 Subject: [PATCH 3/3] Update PR template --- .github/PULL_REQUEST_TEMPLATE.md | 39 ++++++++++++++++++++------------ 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 20d3e08..e4b253b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,19 +1,28 @@ -## Summary +## What's this PR do? + -**Issue:** #ISSUE_NUMBER +## Why are we doing this? + -Replace "ISSUE_NUMBER" with the number of your issue so that GitHub will link this pull request with the issue and make review easier. +## Steps to manually test + -All checks are run in [GitHub Actions](https://github.com/features/actions). You'll be able to see the results of the checks at the bottom of the pull request page after it's been opened, and you can click on any of the specific checks listed to see the output of each step and debug failures. - -- [ ] Tests are implemented -- [ ] All tests are passing -- [ ] Style checks run (see [documentation](https://cityscrapers.org/docs/development/) for more details) -- [ ] Style checks are passing -- [ ] Code comments from template removed - -## Questions - -Include any questions you have about what you're working on. +## Are there any smells or added technical debt to note? +