Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ Fix: Azure status badge creation #63

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

SimmonsRitchie
Copy link
Contributor

What's this PR do?

Fixes Azure env vars that are intended to create a status badge indicating whether a spider successfully ran or failed during the cron workflow.

Why are we doing this?

This env var misconfiguration issue was causing the status badge to not be created when a spider successfully runs or fails in prod. It has been observed in a number of city-scraper repos.

Steps to manually test

  1. Run the cron workflow using this branch
  2. Observe the logs during the run spider step (search the logs for "svg"). You should see status badge svg links succesfully being created and exported to an Azure container.
  3. Check either the Azure container to check that the files were successfully uploaded or check the Documenters.org scraper status page.

Are there any smells or added technical debt to note?

n/a

@SimmonsRitchie SimmonsRitchie marked this pull request as ready for review February 27, 2024 21:59
@SimmonsRitchie SimmonsRitchie merged commit 46035a5 into main Feb 27, 2024
3 checks passed
@SimmonsRitchie SimmonsRitchie deleted the fix-azure-badge branch February 27, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant