Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Keycloak authentication #1323

Merged
merged 11 commits into from
Sep 20, 2024
Merged

Add support for Keycloak authentication #1323

merged 11 commits into from
Sep 20, 2024

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Sep 9, 2024

🛠️ Changelog

  • Replaces Tunnistamo login system with Keycloak one.
  • Migrates existing Tunnistamo user data to the new Keycloak user
  • Adds support for logout redirect urls
  • Logout all users when this change goes live via a migration
  • Rewrite the Tunnistamo client as Keycloak client and use it in the Helsinki Profile client.

🧪 Test plan

  • Automated tests
  • Manual tests

🚧 Dependencies

🎫 Tickets

@matti-lamppu matti-lamppu added feature Adds a new feature breaking Requires frontend changes labels Sep 9, 2024
@matti-lamppu matti-lamppu self-assigned this Sep 9, 2024
@City-of-Helsinki City-of-Helsinki deleted a comment from github-actions bot Sep 10, 2024
api/helauth/views.py Outdated Show resolved Hide resolved
users/helauth/pipeline.py Outdated Show resolved Hide resolved
users/helauth/pipeline.py Outdated Show resolved Hide resolved
users/helauth/pipeline.py Outdated Show resolved Hide resolved
@matti-lamppu matti-lamppu changed the base branch from main to generate-reservation-series-holidays September 18, 2024 05:10
Base automatically changed from generate-reservation-series-holidays to ical September 18, 2024 11:05
Base automatically changed from ical to main September 18, 2024 11:14
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
57.7% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@matti-lamppu matti-lamppu merged commit f5d56ee into main Sep 20, 2024
9 of 10 checks passed
@matti-lamppu matti-lamppu deleted the keycloak branch September 20, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Requires frontend changes feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants