Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date picker problems #1368

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Fix date picker problems #1368

merged 4 commits into from
Sep 12, 2024

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Aug 30, 2024 •
edited by jira bot
Loading

🛠️ Changelog

  • Fix: date input crashing
  • Fix: responsive issues in my-units (mobile layout breaking on second tab and with Date selector).
  • Refactor: remove old Tabs component (and use query params directly).
  • Refactor: remove duplicated DateInput component (moved to common).
  • Refactor: move DayNavigation to query param filters (the only use case for it).

🧪 Test plan

  • Manual testing: bug tickets and responsiveness of my-units page (admin-ui).

🎫 Tickets

vincit-matu
vincit-matu approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@vincit-matu vincit-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joonatank joonatank force-pushed the rework-permissions branch 4 times, most recently from b16b740 to b0e7070 Compare September 5, 2024 06:46
Base automatically changed from rework-permissions to main September 5, 2024 09:35
@joonatank joonatank changed the base branch from main to fix-cant-modify-seasonal-reservation September 12, 2024 11:44
@joonatank joonatank merged commit e81a50f into fix-cant-modify-seasonal-reservation Sep 12, 2024
6 checks passed
@joonatank joonatank deleted the fix-date-picker-problems branch September 12, 2024 11:45
@joonatank joonatank mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu vincit-matu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonatank @vincit-matu