Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reservationUnit state properties as per backend changes #1376

Conversation

vincit-matu
Copy link
Contributor

@vincit-matu vincit-matu commented Sep 2, 2024

🛠️ Changelog

  • Renames reservation unit state properties as per the changes in the backend
    • reservationUnit.state => reservationUnit.publishingState
    • ReservationState=> ReservationUnitReservationState
  • requires the back end changes in PR #1278 to work (==not break)

🧪 Test plan

  • Everything reservation unit state related should work as it did before the change

🎫 Tickets

  • TILA-3473

@vincit-matu vincit-matu marked this pull request as ready for review September 2, 2024 21:46
Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

- reservationUnit.state => reservationUnit.publishingState
- ReservationState => ReservationUnitReservationState
@joonatank joonatank force-pushed the refactor-reservation-unit-state-properties branch from 1a3f28b to 9f12ddc Compare September 12, 2024 11:58
@joonatank joonatank merged commit ba2bbc6 into fix-cant-modify-seasonal-reservation Sep 13, 2024
6 checks passed
@joonatank joonatank deleted the refactor-reservation-unit-state-properties branch September 13, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants