Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor organise admin-ui code #1377

Merged
merged 15 commits into from
Sep 13, 2024
Merged

Refactor organise admin-ui code #1377

merged 15 commits into from
Sep 13, 2024

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Sep 3, 2024

🛠️ Changelog

  • Reorganise admin-ui so pages are under spa not components
  • Remove unnecessary edit, /recurring-reservations, and /premises-and-settings/ from urls.
  • Refactor: use url builders for all internal links.
  • Remove unnecessary spaces and resources listing pages that were not linked from anywhere.
  • Remove copy of a HDS Table component (use HDS instead).

🧪 Test plan

  • Manual testing: check most common functionality. Links and tables (sorting) refactored. admin-ui only

🎫 Tickets

@joonatank joonatank marked this pull request as ready for review September 3, 2024 19:46
@joonatank joonatank force-pushed the refactor-organise-code-actual branch 3 times, most recently from 9c71ac6 to fcb4336 Compare September 4, 2024 07:04
@joonatank joonatank changed the title Refactor organise code actual Refactor organise admin-ui code Sep 4, 2024
Base automatically changed from rework-permissions to main September 5, 2024 09:35
@joonatank joonatank force-pushed the refactor-organise-code-actual branch 5 times, most recently from 5cd49e8 to 9980b67 Compare September 11, 2024 08:23
@joonatank joonatank force-pushed the refactor-organise-code-actual branch 2 times, most recently from 05d8a70 to b980f13 Compare September 12, 2024 06:56
@joonatank joonatank changed the base branch from main to refactor-reservation-unit-state-properties September 12, 2024 11:57
@joonatank joonatank changed the base branch from refactor-reservation-unit-state-properties to main September 12, 2024 11:57
@joonatank joonatank changed the base branch from main to refactor-reservation-unit-state-properties September 12, 2024 12:02
Base automatically changed from refactor-reservation-unit-state-properties to fix-cant-modify-seasonal-reservation September 13, 2024 08:58
Base automatically changed from fix-cant-modify-seasonal-reservation to main September 13, 2024 09:26
@joonatank joonatank enabled auto-merge (rebase) September 13, 2024 10:12
@joonatank joonatank merged commit de827c4 into main Sep 13, 2024
6 checks passed
@joonatank joonatank deleted the refactor-organise-code-actual branch September 13, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants