Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove search result count #1378

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: remove search result count #1378

merged 1 commit into from
Oct 3, 2024

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Sep 4, 2024 •
edited by jjuvonen
Loading

🛠️ Changelog

  • Remove ui search page count because it's miss leading to the user as we don't know the total count so it looks like there are no more result.

🧪 Test plan

  • Manual testing: search page only thing that should have changed is the count before the list is removed (the one next to load more is still intact).

🎫 Tickets

  • TILA-3550

@joonatank joonatank changed the base branch from main to update-deps October 3, 2024 06:52
@joonatank joonatank merged commit e1b7a1c into update-deps Oct 3, 2024
6 checks passed
@joonatank joonatank deleted the fix-remove-search-result-count branch October 3, 2024 06:52
@joonatank joonatank mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu vincit-matu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonatank @vincit-matu