Fix tags #1384
Merged
Fix tags #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonatank
reviewed
Sep 5, 2024
vincit-matu
force-pushed
the
fix-tags
branch
2 times, most recently
from
a8fd431
to
414c5e3
Compare
- our StatusLabel extends the HDS StatusLabel, to also handle the “draft” type - and uses tilavaraus colour-scheme
- removes isArchived as unnecessary
- add unique id’s to the search result status tags - add unique id’s to the admin ui search filter tags - make the tag id for the next available time unique (status- tag-#pk) - refactor deprecated Tag attribute deleteButtonAriaLabel to just plain aria-label
joonatank
changed the base branch from
main
to
refactor-reservation-unit-state-properties
Base automatically changed from
refactor-reservation-unit-state-properties
to
fix-cant-modify-seasonal-reservation
September 13, 2024 08:58
joonatank
merged commit c954ad3
into
fix-cant-modify-seasonal-reservation
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changelog
StatusLabelcomponent to common, which is a HDS StatusLabel extended with the "draft" typeTags withStatusLabels where appropriateids toTags which appear on pages with more than oneTagdeleteButtonAriaLabelwith plainaria-labelisArchivedfrom the reservation unit list, as well as the corresponding gql-query (and gql-types)🧪 Test plan
ids if there are several tags on a page🎫 Tickets