Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: try catch mutations #1400

Merged
merged 6 commits into from
Oct 17, 2024
Merged

refactor: try catch mutations #1400

merged 6 commits into from
Oct 17, 2024

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Sep 11, 2024 •
edited
Loading

🛠️ Changelog

  • Refactor: use try catch instead of hooks for mutations (style consistency and some weird issues with callbacks).

🧪 Test plan

  • Manual testing: Reservation approval / deny buttons should work as before (including refunding payment) admin-ui

🎫 Tickets

  • TILA-####

@joonatank joonatank force-pushed the refactor-approval-buttons-mutations branch from 9e568d7 to 051881f Compare September 11, 2024 08:23
vincit-matu
vincit-matu approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@vincit-matu vincit-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joonatank joonatank force-pushed the refactor-organise-code-actual branch 5 times, most recently from 1fa78e0 to 02a8649 Compare September 13, 2024 10:11
Base automatically changed from refactor-organise-code-actual to main September 13, 2024 10:13
@joonatank joonatank force-pushed the refactor-approval-buttons-mutations branch from 051881f to ce1c7be Compare September 13, 2024 10:37
@joonatank joonatank force-pushed the refactor-approval-buttons-mutations branch from ce1c7be to 17f2410 Compare October 10, 2024 04:11
@joonatank joonatank force-pushed the refactor-approval-buttons-mutations branch from 17f2410 to 914ceb5 Compare October 17, 2024 08:55
@joonatank joonatank force-pushed the refactor-approval-buttons-mutations branch from 914ceb5 to 37781e9 Compare October 17, 2024 08:56
@joonatank
Copy link
Contributor Author

Using as a base for PRs: #1449, #1450, #1415, #1453, #1455

@joonatank joonatank merged commit d1d618d into main Oct 17, 2024
8 checks passed
@joonatank joonatank deleted the refactor-approval-buttons-mutations branch October 17, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu vincit-matu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonatank @vincit-matu