Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UI reservation #1402

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Refactor UI reservation #1402

wants to merge 29 commits into from

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Sep 12, 2024

🛠️ Changelog

  • Refactor new and edit reservation to use same Calendar picker component.
  • Add: quick slot select to edit reservation.
  • Fix: only include active applications when checking reservability.
  • Fix: redirect after edit then toast (not the other way).
  • Fix: updated Calendar Legend.
  • Fix: improve performance in reservability checks when there are thousands of reservations.
  • Refactor: cleanup HTML / CSS structure of reservation pages (single grid).
  • Refactor: move inner JSX code to separate components / lists.
  • Fix: add a check for reservation editability on edit page.
  • Remove: touch device calendar hacks.

🧪 Test plan

  • Manual testing: new reservation and edit reservation should work, and should be consistent (with all three controls).

🎫 Tickets

@joonatank joonatank force-pushed the refactor-ui-reservation branch 13 times, most recently from fb00576 to afe51d1 Compare September 16, 2024 06:44
@joonatank joonatank self-assigned this Sep 16, 2024
@joonatank joonatank marked this pull request as ready for review September 16, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant