Remove Arduino IDE support #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been depending on PlatformIO for awhile now: it has better modern C++ support and makes OTA signing easier, to name a couple of reasons. It was useful to have a period of supporting both PIO and the Arduino IDE, but at this point I think PIO needs to be our primary build system. Anyone who contributes to the firmware in the future needs to be able to work/test with PIO anyway.
These commits remove code related to Arduino IDE support and flags that managed the dual support. This includes the removal of the
config.hheader, which was the source of some problems in the past since it was easy to forget about.