Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WordPress.org repository as a source #69

Open
viktorix opened this issue Jan 30, 2023 · 4 comments
Open

Add WordPress.org repository as a source #69

viktorix opened this issue Jan 30, 2023 · 4 comments
Labels
enhancement New feature or request status: discussion Discussion ongoing, no decision made yet.

Comments

@viktorix
Copy link
Member

This issue is created to continue the discussion started in the forum about adding WordPress.org repository as a source.

If we simply treat it as a repository source, regardless of its rules, it shouldn't be a problem adding it to the directory. It is developer's choice to use WordPress.org instead of a Git-based source. It is also developers responsibility to follow WP repos rules to stay listed. If WordPress closes the plugin/theme, API no longer returns any data and ClassicPress directory would suspend such plugin/theme pending a review.

For this integration to work, WordPress.org API must be used similarly to GitHub API. For example:
https://api.wordpress.org/plugins/info/1.0/wordpress-seo.json

The API returns the necessary data for the directory to do its job:

  • download_link - provides URL to a zip file with the latest version.
  • description - can be used as a fallback for the item's description, similarly to how fallback works with README.md in the repository.

Plugins/themes would still need to follow all the requirements and rules to be listed in the directory, this includes passing CPCS. Listing in WordPress repository doesn't guarantee listing in ClassicPress directory.

The update process would be handled through the directory as we have a new process being put in place to default to CP directory. If Update URI is empty and Requires CP is set, ClassicPress core will default to use directory for updates. So there should be no issues.

Important to remember: A WordPress plugin installed through original WP core integration will default to use CP directory for updates because it will have Requires CP set.

This could lead to WP repo integration removal from CP core, if WP plugins/themes begin to get listed in the directory.

This is only a discussion right now, open to feedback.

@viktorix viktorix added enhancement New feature or request status: discussion Discussion ongoing, no decision made yet. labels Jan 30, 2023
@ClassyBot
Copy link
Collaborator

This issue has been mentioned on ClassicPress Forums. There might be relevant details there:

https://forums.classicpress.net/t/plugin-theme-updates-directory-integration/4558/44

@xxsimoxx
Copy link
Member

Since asking to follow our guidelines is something that requires several changes, for me is not something blocking asking also to keep a GitHub repo. Also considering that there are a lot of plugins using GitHub actions to manage SVN.

I've checked some random WP plugins with cpcs, and a lot of changes were required.

I'm thinking if a viable option can be to have a list of "whitelisted" WP plugin. We just check that the plugin don't use removed functions, insert the slug in an API and just leave them in WP page with something like this:

Schermata 2023-01-31 alle 13 56 42

@tradesouthwest
Copy link

Maybe I can play the Devil's Advocate here and ask a question: Is it possible to host an Subversion svn network 99% akin to what WP uses at current; or is an SVN network too costly to host for an open source project such as CP.

This is a generalized question, I'm asking, since there are plenty of ancillary parameters to consider such as "importing" or "inviting" current WP plugin authors to list theirs on CP svn, voluntarily, rather than crawling WP's repo as an engine function. But for now I ask the simplest observations for this conversation.

@tradesouthwest
Copy link

tradesouthwest commented Feb 12, 2023

Or even a simple API like namespace WPDM\Admin\Menu; uses in wordpress download manager plugin: https://www.wpdownloadmanager.com/?wpdm_api_req=getPackageList

What is really nice about this is the MINIMAL UI of the (add-ons) admin page.
Screenshotfrom2023-02-12-12-27-33

Thoughts on the simplicity of this UI over the WP interface that has Icons; and the moving gifs, that have been an issue w/ WP repo. Less bandwidth. Maybe add a description/plugin_url link that opens externally. Simple is always better. Less "moving parts" and easy on the eyes.

Hope this is the correct thread for plugin repo build issue submitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status: discussion Discussion ongoing, no decision made yet.
Projects
None yet
Development

No branches or pull requests

4 participants