Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Typecheck components in CI #1136

Merged
merged 38 commits into from
Sep 30, 2024
Merged

Conversation

florian-sanders-cc
Copy link
Contributor

@florian-sanders-cc florian-sanders-cc commented Aug 1, 2024

Fixes #1113

What does this PR do?

  • Fixes typechecking issues within most of components,
  • Adds all components that pass typechecking to the CI typechecking (exclude others).

How to review?

  • Check every commit (there are many but most of them contain very simple changes),
  • Compare prod & preview stories for the following components:
    • cc-addon-backups,
    • cc-addon-*-options all components,
    • cc-env-var-* all components,
    • cc-invoice-* all components,
    • cc-logsmap,
    • cc-map-* all components,
    • cc-tile-status-codes,
    • cc-warning-payment,
    • cc-popover.
  • That's it, CI takes care of the rest 😉

@pdesoyres-cc
Copy link
Contributor

maybe this branch could help: https://github.com/CleverCloud/clever-components/tree/more-typechecking.

@florian-sanders-cc
Copy link
Contributor Author

👀 I didn't know you were typechecking the libs eheh

Well the TypeChecking works for every file listed (+ their dependencies, which is why I typechecked the libs as well). It's just not ready for review because I need to review it myself before + split into separate commits.

@florian-sanders-cc florian-sanders-cc force-pushed the typecheck-components branch 5 times, most recently from bf1537c to 22dd5ca Compare August 9, 2024 18:07
@florian-sanders-cc florian-sanders-cc force-pushed the typecheck-components branch 15 times, most recently from 0d89141 to fd483a7 Compare September 6, 2024 12:00
Copy link
Contributor

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/typecheck-components/index.html.

This preview will be deleted once this PR is closed.

@florian-sanders-cc florian-sanders-cc force-pushed the typecheck-components branch 4 times, most recently from 9b1b0d1 to 6c7f4d9 Compare September 11, 2024 13:52
@florian-sanders-cc florian-sanders-cc merged commit cceb2e9 into master Sep 30, 2024
4 checks passed
@florian-sanders-cc florian-sanders-cc deleted the typecheck-components branch September 30, 2024 14:52
Copy link
Contributor

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Typechecking: add all component that pass typechecking to the CI task
3 participants