Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cem-types-plugin): ignore non relative path imports #1148

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

Galimede
Copy link
Member

@Galimede Galimede commented Sep 5, 2024

What does this PR do?

  • When using bare imports in the types, the plugin tried to look up in the corresponding file the subtypes. However, we don't want that and only want to use the type from the bare import.
  • This PR also makes the plugin exit to 1 if an error has been detected.

@florian-sanders-cc
Copy link
Contributor

LGTM! Thanks for fixing this issue so quickly 🚀

Copy link
Contributor

github-actions bot commented Sep 5, 2024

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/plugin-types-fix-import/index.html.

This preview will be deleted once this PR is closed.

@Galimede Galimede merged commit 3a1af97 into master Sep 5, 2024
4 checks passed
@Galimede Galimede deleted the plugin-types-fix-import branch September 5, 2024 09:34
Copy link
Contributor

github-actions bot commented Sep 5, 2024

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants