Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cc-block): fix css and description text #1210

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

HeleneAmouzou
Copy link
Contributor

@HeleneAmouzou HeleneAmouzou commented Oct 22, 2024

What does this PR do?

  • cc-env-var-form : adds plural to "variable" in description text and removes unnecessary "En savoir plus / Learn more" in description text,
  • cc-block : removes margin bottom,
  • cc-domain-management : reverts to initial gap,
  • cc-invoice: remove unnecessary padding.

How to review?

  • Check the commit,
  • Check the components in preview

Copy link
Contributor

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-block/fix-component/index.html.

This preview will be deleted once this PR is closed.

@HeleneAmouzou HeleneAmouzou self-assigned this Oct 22, 2024
Copy link
Contributor

@florian-sanders-cc florian-sanders-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small nitpick, you have a typo in the first commit desc:

fix(cc-env-var-form): remove unnecessary link and fix type in description text
should be:

fix(cc-env-var-form): remove unnecessary link and fix typo in description text

Apart from that it's great, gj 😉

Copy link
Member

@hsablonniere hsablonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @HeleneAmouzou, I think we should keep the Learn more links for "exposed-config" and "config-provider" as they're not the same as the link in the footer (which is also useful).

src/translations/translations.en.js Outdated Show resolved Hide resolved
src/translations/translations.en.js Show resolved Hide resolved
src/translations/translations.en.js Outdated Show resolved Hide resolved
src/translations/translations.fr.js Outdated Show resolved Hide resolved
src/translations/translations.fr.js Outdated Show resolved Hide resolved
src/translations/translations.fr.js Show resolved Hide resolved
@HeleneAmouzou HeleneAmouzou dismissed stale reviews from hsablonniere and florian-sanders-cc October 22, 2024 14:35

I have made the requested changes

@HeleneAmouzou HeleneAmouzou merged commit b0761c1 into master Oct 22, 2024
4 checks passed
@HeleneAmouzou HeleneAmouzou deleted the cc-block/fix-component branch October 22, 2024 14:39
Copy link
Contributor

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants