-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cc-block): fix css and description text #1210
Conversation
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-block/fix-component/index.html. This preview will be deleted once this PR is closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a small nitpick, you have a typo in the first commit desc:
fix(cc-env-var-form): remove unnecessary link and fix type in description text
should be:
fix(cc-env-var-form): remove unnecessary link and fix typo in description text
Apart from that it's great, gj 😉
6fceb9e
to
77f366a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @HeleneAmouzou, I think we should keep the Learn more
links for "exposed-config" and "config-provider" as they're not the same as the link in the footer (which is also useful).
3555d9e
to
458a488
Compare
I have made the requested changes
🔎 The preview has been automatically deleted. |
What does this PR do?
cc-env-var-form
: adds plural to "variable" in description text and removes unnecessary "En savoir plus / Learn more" in description text,cc-block
: removes margin bottom,cc-domain-management
: reverts to initial gap,cc-invoice
: remove unnecessary padding.How to review?