fix(cc-domain-management): allow newly added domain to be marked as primary #1214
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-sanders-cc
force-pushed
the
cc-domain-management/fix-newly-added-domain-as-primary
branch
from
404575d
to
b75322f
Compare
Comment on lines
-110
to
-112
| const hasPathPrefix = pathPrefix != null && pathPrefix !== '/'; | ||
| // TODO: once the API returns actual ids, this should be adapted (either refetch or use the API response) | ||
| const id = hasPathPrefix ? hostname + pathPrefix : hostname; |
There was a problem hiding this comment.
I cannot remember why I did that in the first place :/ I do remember that there were conflicts with some API routes not handling the trailing slash properly but it seems to work fine without it and usually I leave a comment to explain why I did something weird so it may be something I forgot to remove?
There was a problem hiding this comment.
I think the issue was as follows:
- when adding a new domain, I used to not send trailing slashes to the API because that's what was done before,
- so the
idwas thehostnamewithout the path prefix if the path prefix was just "/", - but at some point I decided to send trailing slashes to the API when adding a domain and I forgot to update the
idhere to reflect that.
florian-sanders-cc
force-pushed
the
cc-domain-management/fix-newly-added-domain-as-primary
branch
from
b75322f
to
68c3961
Compare
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-domain-management/fix-newly-added-domain-as-primary/index.html. This preview will be deleted once this PR is closed. |
hsablonniere
approved these changes
Oct 22, 2024
florian-sanders-cc
deleted the
cc-domain-management/fix-newly-added-domain-as-primary
branch
|
🔎 The preview has been automatically deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1213
What does this PR do?
How to review?
localhost:6006/demo-smart/,cc-domain-management,app-node: