Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cc-flex-gap): Remove the component and replace it with CSS #768

Merged
merged 16 commits into from
Jun 26, 2023

Conversation

florian-sanders-cc
Copy link
Contributor

@florian-sanders-cc florian-sanders-cc commented Jun 13, 2023

Fixes #769

What does this PR do?

  • Removes the cc-flex-gap component,
  • Replaces it usage with CSS,
  • Improves responsiveness of some components.

Note:

  • This PR does not modify cc-pricing-* components and cc-zone. It should be merged after the pricing PR.

Things to check

  • every commit,
  • compare these components visually with prod:
    • cc-toaster story
    • cc-tcp-redirection
    • cc-invoice-table
    • cc-heptapod-info
    • cc-header-orga
    • cc-header-app
    • cc-header-addon
    • cc-env-var-input
    • cc-env-var-form
    • cc-env-var-create
    • cc-elasticsearch-info
    • cc-addon-credentials
    • cc-addon-linked-apps
    • cc-addon-features

TODO (Flo)

  • Rebase and fixup feedback commits

@florian-sanders-cc florian-sanders-cc changed the title feat(tmp): tmp commit, split & clean for PR feat(cc-flex-gap): Remove the component and replace it with CSS Jun 13, 2023
@florian-sanders-cc florian-sanders-cc linked an issue Jun 13, 2023 that may be closed by this pull request
2 tasks
@github-actions
Copy link
Contributor

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-flex-gap/remove/index.html.

This preview will be deleted once this PR is closed.

Copy link
Contributor

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Flo! I've got nothing to say.

Copy link
Member

@Galimede Galimede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, nice job on changing them, I've checked the components as you asked and I found some things that I left below. Otherwise good job! 💪

  • question: cc-header-orga has an alignment difference, is this voluntary?
  • nitpick(non-blocking): there is a slight alignment difference for cc-env-var-input but it's barely noticeable so we can leave it like that I guess. As the cc-env-var-form contains some cc-env-var-input you can see it in the component too.
  • issue: the alignment with the zone is broken on cc-addon-linked-apps

(:warning: Watch out you put cc-addon-credentials twice in the components to review visually 😉)

Copy link
Member

@roberttran-cc roberttran-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very thorough PR, as usual: very nice job!

I have the same feedback as Mathieu on:

  • cc-addon-linked-apps: cc-zone alignment is off with the beginning of the line
  • cc-header-orga: space is missing between the main name and the badge

I'll also add:

  • cc-header-addon: breakpoints when content should wrap is broken

@florian-sanders-cc
Copy link
Contributor Author

florian-sanders-cc commented Jun 23, 2023

Thanks for your reviews @Galimede @roberttran-cc!

cc-header-orga:
Oups, forgot to reset a test I made. I still find the spacing between "hotline" and the badge below weird but it's roughly the same as prod now 👍

cc-addon-linked-apps:
Fixed 👍 The alignment is more centered than in prod now. I think it's better this way but WDYT?

cc-header-addon:
Very good catch @roberttran-cc. I fixed it. There might still be a slight difference but the component can shrink below 450px compared to the one in prod so I think it's for the best 👍.

cc-env-var-input:
You are right @Galimede, I did not see at first but now I do. I'd say we can leave it like that 👍.

I made separate commits for your fixes so you can check them easily (cc-zone + the ones with your names 😉)

Copy link
Member

@roberttran-cc roberttran-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc-header-orga, cc-header-addon, cc-env-var-input : perfect!

cc-addon-linked-apps: I made a suggestion on how to fix the issue, tell me what you think about it!

src/components/cc-zone/cc-zone.js Outdated Show resolved Hide resolved
@florian-sanders-cc florian-sanders-cc force-pushed the cc-flex-gap/remove branch 2 times, most recently from 91606a3 to 259173b Compare June 23, 2023 08:14
Copy link
Member

@Galimede Galimede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, GG! 💪

@florian-sanders-cc florian-sanders-cc force-pushed the cc-flex-gap/remove branch 2 times, most recently from f9c6835 to 51666f6 Compare June 26, 2023 12:14
@florian-sanders-cc florian-sanders-cc merged commit 2a81406 into master Jun 26, 2023
@florian-sanders-cc florian-sanders-cc deleted the cc-flex-gap/remove branch June 26, 2023 12:32
@github-actions
Copy link
Contributor

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove/deprecate <cc-flex-gap>
4 participants