Update lit-analyzer to fix ref and lit 2 directive issues
#779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-sanders-cc
requested review from
hsablonniere,
pdesoyres-cc,
Galimede and
roberttran-cc
hsablonniere
approved these changes
Jun 20, 2023
florian-sanders-cc
force-pushed
the
lit-analyzer/update
branch
2 times, most recently
from
59e1add
to
46edf84
Compare
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/lit-analyzer/update/index.html. This preview will be deleted once this PR is closed. |
florian-sanders-cc
force-pushed
the
lit-analyzer/update
branch
from
46edf84
to
7ec5d38
Compare
|
🔎 The preview has been automatically deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #679
Fixes #778
What does this PR do?
lit-analyzerto2.0.0-pre.3. I chose to stick with the specific version and not "^" because these are not stable releases. WDYT?refdirective.globalAttributesworkaround fromtsconfig.json.How to review
Run
npm run components:check-lit=> there should be 0 error.I've already checked that the following components are still working correctly (focus handling mostly):
cc-orga-member-list,cc-orga-member-card,cc-ssh-key-list,cc-tile-metricscc-pricing-estimation(newly merged).