cc-pricing-*: update components for the new website (clean commit messages) #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-pricing/update/index.html. This preview will be deleted once this PR is closed. |
florian-sanders-cc
force-pushed
the
cc-pricing/update
branch
4 times, most recently
from
5d94771
to
269135c
Compare
BREAKING CHANGE: see details below - add new way of handling the component state and passing data to the component. - remove the heading, desc and image/logo slots. - use the new smart API. - directly render a table within the component instead of relying on a `cc-pricing-table` sub-component to do so. - merge the `cc-pricing-table` component and stories into `cc-pricing-product`.
BREAKING CHANGE: The `cc-pricing-table` component has been merged into the `cc-pricing-product` component.
BREAKING CHANGE: see more details below - add new way of handling the component state and passing data to the component. - the smart component now uses the new smart API. - remove the slots for heading, description and image.
…nstead of cc-error
florian-sanders-cc
force-pushed
the
cc-pricing/update
branch
from
269135c
to
8f1fa04
Compare
florian-sanders-cc
force-pushed
the
cc-pricing/update
branch
from
8f1fa04
to
1882904
Compare
7 tasks
pdesoyres-cc
approved these changes
Jun 21, 2023
BREAKING CHANGE: see more details below - add new way of handling the component state and passing data to the component. - use the new smart API. - add a temporality selector component.
BREAKING CHANGE: see more details below - add new way of handling the component state and passing data to the component. - use the new smart API.
BREAKING CHANGE: We needed to be able to style and move the pricing components inside the `cc-pricing-page` component a lot more. For instance, the `cc-pricing-header` can now be positioned wherever one wants within the `cc-pricing-page` because everything is slotted within the `cc-pricing-page`. The smart `cc-pricing-page` smart component was mainly interacting with `cc-pricing-header` data (fetching `zones`). This is why we removed the `cc-pricing-page.smart` part and added a `cc-pricing-header.smart`.
florian-sanders-cc
force-pushed
the
cc-pricing/update
branch
from
1882904
to
68f4d67
Compare
|
🔎 The preview has been automatically deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #692
Context
These modifications had already been merged (see #716) but the generated changelog from release please was empty because our commit messages did not follow the proper format.
This PR fixes the commit messages format in order to generate a proper changelog.