Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also add actions:write permission to actions/stale #75193

Merged

Conversation

kevingranade
Copy link
Member

Summary

None

Purpose of change

This is needed for cache handling with the current version. They have an issue open at actions/stale#1133 about it.

Describe the solution

Add the permission.

Describe alternatives you've considered

Reportedly we could lock actions/stale to version 8 instead.
It's possible it's just getting confused because the current cache file was created by a manually invoked run of the action?

Additional context

It looks like either the stale action or the cache infrastructure (not clear which) is using the action definition as part of a checksum for ownership of the state file, and if it's different it can't delete the cache without these additional permissions.

This is needed for cache handling with the current version.
They have an issue open at actions/stale#1133 about it.
@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 23, 2024
@kevingranade kevingranade merged commit f5d14b3 into master Jul 23, 2024
16 of 22 checks passed
@kevingranade kevingranade deleted the kevingranade-stale-action-even-more-permissions branch July 23, 2024 20:23
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant