Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence on PyCall #18

Open
charleskawczynski opened this issue Jan 29, 2020 · 7 comments
Open

Remove dependence on PyCall #18

charleskawczynski opened this issue Jan 29, 2020 · 7 comments

Comments

@charleskawczynski
Copy link
Member

charleskawczynski commented Jan 29, 2020

It looks like PyCall is only used to for the wasserstein_distance. It looks like we can call it from EarthMoversDistance.jl

@dburov190
Copy link
Contributor

No, EarthMoversDistance.jl is a poor wrapper of an even poorer implementation from last century; I've tried it, it crashes every other time and is very slow. Python code works without hiccups.

@charleskawczynski
Copy link
Member Author

I'd like to keep this issue open, since removing the dependence on PyCall would significantly reduce the build/development time-- even if that means translating python's wasserstein_distance

@dburov190
Copy link
Contributor

Yeah, I mean, we could just rewrite that piece in Julia -- but it's very unlikely to be fixed in the nearest future (: I'm happy with python for now, since it works really well and fast.

@odunbar
Copy link
Collaborator

odunbar commented Feb 22, 2020

I know I am late to the party here, but SKlearn also involves python calls. And GaussianProcesses.jl is again very slow (regards to optimization of hyperparameters) for when I tried this, so for now this will remain in the code too.

@charleskawczynski
Copy link
Member Author

Agreed, I think this is more of a long term issue to resolve (if possible/feasible)

@jakebolewski
Copy link
Contributor

I wonder if GaussianProcesses has matured somewhat in the meantime, is there a good comparative performance benchmark to try?

@charleskawczynski
Copy link
Member Author

xref: JuliaStats/Distances.jl#159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants