-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package name #12
Fix package name #12
Conversation
4ea7e3b
to
bda555d
Compare
4a1d7d1
to
34263cd
Compare
|
||
Peform an iteration of NEKI, returning a new set of proposed `θs`. | ||
Perform an iteration of NEKI, returning a new set of proposed `θs`. | ||
|
||
See eqs. (5.4a-b) from https://arxiv.org/abs/1903.08866. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update reference, @agarbuno?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change this to https://arxiv.org/pdf/2001.03689.pdf
?
0109d78
to
916312c
Compare
Not sure if the plan is to register this as a Julia package but the name CES.jl might get rejected as it goes against naming guidelines 1 and 4: https://julialang.github.io/Pkg.jl/v1/creating-packages/#Package-naming-guidelines-1
CalibrateEmulateSample.jl would be accepted automatically I suspect. |
Thanks @ali-ramadhan! Good point. We'll want to change the name, but I'm not sure what the final name should be. I'm probably not the person to decide on the name. This PR just makes the naming consistent because, before, |
Is |
‘CalibrateEmulateSample.jl’ is good. You can also use ‘EnsembleKalmanSampler’ for ‘EKS’. |
Please also change the 1e-8 to ‘sqrt(eps)’. Whatever small effect it has on results is not material. We should address such issues when we can. Github issues seem to linger for a long time before being acted upon. |
916312c
to
2cc2543
Compare
2cc2543
to
67feaaf
Compare
Closes #13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this does break a bit of my stuff (examples directory), hold off a little bit, I'll fix that soon and then we can merge.
Let me know if there's anything I can help with. |
@dburov190 @odunbar any updates on merging this? |
Hi @odunbar, @dburov190, and @agarbuno
We need to standardize the package name. Please check that these changes don't break any results/tests. If they don't, feel free to merge and we can push forward. Once this is configured, we can set up some automated CI, so that changes can be made more easily.
Note that I've also changed the tolerance of
1e-8
tosqrt(eps(Float64))