Add periodic boundary condition when lat is 360° #164
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 11 11
Lines 1206 1207 +1
=======================================
+ Hits 1186 1187 +1
Misses 20 20 ☔ View full report in Codecov by Sentry. |
Sbozzolo
reviewed
Nov 15, 2024
src/Var.jl
Outdated
| @@ -166,6 +166,10 @@ function _find_extp_bound_cond(dim_name, dim_array) | |||
| _isequispaced(dim_array) && | |||
| isapprox(dim_size + dsize, 360.0) | |||
| ) && return Intp.Periodic() | |||
| ( | |||
| conventional_dim_name(dim_name) == "longitude" && | |||
| (dim_array[end] - dim_array[begin]) == 360.0 | |||
There was a problem hiding this comment.
Suggested change
| (dim_array[end] - dim_array[begin]) == 360.0 | |
| (dim_array[end] - dim_array[begin]) ≈ 360.0 |
Better account for floating point errors
Sbozzolo
approved these changes
Nov 15, 2024
ph-kev
force-pushed
the
kp/more-extrapolations
branch
from
b991f66
to
7a9e98f
Compare
When the difference between the longitude dimension is exactly 360.0 degrees, then a periodic boundary condition is added.
ph-kev
force-pushed
the
kp/more-extrapolations
branch
from
7a9e98f
to
8bd71ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #163 - When the difference between the longitude dimension is exactly 360.0 degrees, then a periodic boundary condition is added.